#10885: Floyd-Warshall algorithm in Cython
-------------------------------------------------+--------------------------
Reporter: ncohen | Owner: jason, ncohen,
rlm
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: graph theory | Keywords:
Author: Nathann Cohen, Yann Laigle-Chapuy | Upstream: N/A
Reviewer: Nathann Cohen, Yann Laigle-Chapuy | Merged:
Work_issues: |
-------------------------------------------------+--------------------------
Comment(by ylchapuy):
Replying to [comment:9 ncohen]:
> Replying to [comment:8 ylchapuy]:
> > E.g is there any reason 'floyd_warshall' is a function rather than a
method like 'breadth_first_search' ?
>
> Well, what would it return ? There is already a shortest_path_all pairs
and distance_all_pairs in the Graph method, and Floyd-Warshall is not
always the fastest available.
I'm not sure I follow the argument: it does return something, and it's
even documented... Maybe call it '_floyd_warshall' if you don't want the
user to access it.
I might be wrong but it seems to me Sage convention is to prefer methods
instead of functions. Jason, Robert, Minh, any preference on this matter?
> > You might also add one doctest for the ValueError and one for
paths=False and distances=True.
>
> Done !
Great, and it even removed a bug ;)
> Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10885#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
