#10820: tachyon-0.98beta.p11 doesn't build on ARM
----------------------------+-----------------------------------------------
Reporter: Snark | Owner: drkirkby
Type: defect | Status: needs_work
Priority: major | Milestone:
Component: porting | Keywords:
Author: Julien Puydt | Upstream: Reported upstream. Developers
acknowledge bug.
Reviewer: David Kirkby | Merged:
Work_issues: |
----------------------------+-----------------------------------------------
Changes (by drkirkby):
* status: needs_review => needs_work
Comment:
One thing a reviewer should do is to check that all the changes are
committed to the Mercuiral repository - clearly I can't do that unless you
commit the changes to the repository and make an .spkg available so I can
verify it.
The release manager will want to copy your new .spkg into the next Sage
release. For that he needs to be able to download it from somewhere.
So despite the fact your changes are small, you must still make the 2.4 MB
file available for both the reviewer and the release manager.
If you look in any .spkg, you will find a directory {{{.hg}}} which is the
Mercurial repository. Google that.
Since you don't know how to make the changes, I'll explain it. You can
probably find similar in the Sage developers guide.
First create a file {{{$HOME/.hgrc}}}. Here's mine. Make the obvious
changes.
{{{
drkirkby@hawk:~$ cat .hgrc
[ui]
username = David Kirkby <[email protected]>
[extensions]
# Enable the Mercurial queue extension.
hgext.mq =
}}}
I suggest at this point you make a backup of whatever you have done, in
case you mess up.
Next you need to commit your changes to the Mercurial repository in the
.spkg. Do this from the root directory of Sage:
{{{
$ EDITOR=vi # (or use emacs, vim, gedit or what other text editor you
want.)
$ export EDITOR
$ ./sage -sh
}}}
You will get something like this, which is a subshell of Sage.
{{{
Starting subshell with Sage environment variables set.
Be sure to exit when you are done and do not do anything
with other copies of Sage!
Bypassing shell configuration files ...
SAGE_ROOT=/export/home/drkirkby/sage-4.7.alpha1
(sage subshell) hawk:sage-4.7.alpha1 drkirkby$ cd
spkg/standard/tachyon-0.98.9.p3
SAGE_ROOT=/export/home/drkirkby/sage-4.7.alpha1
(sage subshell) hawk:tachyon-0.98.9.p3 drkirkby$ hg commit
}}}
At this point your editor will open. Put on one line
''#10820 Add support of the ARM processor to the Tachyon package''
Save the file. That will commit the changes to the Mercurial repository in
the package. Next you need to create a '''Mercurial''' patch that can be
attached to this ticket.
{{{
SAGE_ROOT=/export/home/drkirkby/sage-4.7.alpha1
(sage subshell) hawk:tachyon-0.98.9.p3 drkirkby$ hg export tip >
$HOME/10820-ARM-support-for-Tachyon.patch
SAGE_ROOT=/export/home/drkirkby/sage-4.7.alpha1
(sage subshell) hawk:tachyon-0.98.9.p3 drkirkby$ exit
exit
Exited Sage subshell.
drkirkby@hawk:~/sage-4.7.alpha1$
}}}
That will create a file $HOME/10820-ARM-support-for-Tachyon.patch which
should be attached to this ticket. That's the only file that needs to be
attached to the ticket - it will contain all the information needed.
Next tar up the package
{{{
$ cd spkg/standard
$ tar cfj tachyon-0.98.9.p3.spkg tachyon-0.98.9.p3
}}}
and post a link to where I can download the complete package. Put that
link in the ticket description too, and make a note that all patches
attached to the ticket are for review purposes only, and that all changes
are committed to the Mercurial repository. That helps the release manager.
I'll then review it. Whist I don't have access to an ARM processor,
assuming things all look OK, I will give it a positive review.
Dave
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10820#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
