#4376: Implement conversion of power series over more rings (e.g. GF(p)) to pari
-----------------------------------------------------------+----------------
Reporter: cremona | Owner: was
Type: enhancement | Status:
positive_review
Priority: major | Milestone:
sage-4.7
Component: interfaces | Keywords:
power series pari gp
Author: Francis Clarke, Jeroen Demeyer | Upstream: N/A
Reviewer: Marco Streng, Jeroen Demeyer, Niles Johnson | Merged:
Work_issues: |
-----------------------------------------------------------+----------------
Changes (by niles):
* status: needs_review => positive_review
* reviewer: Marco Streng, Jeroen Demeyer => Marco Streng, Jeroen
Demeyer, Niles Johnson
Comment:
[attachment:4376_no_strings.patch] looks good: it accomplishes the same
thing as the "with strings" version of the code, but skips the step of
converting a pari polynomial to a string and then back to a pari
polynomial. The patch includes some good corner-case tests, and a comment
referencing the ticket number and what's being fixed.
Therefore, positive review for this patch. If I understand the above
correctly, the other patches here have already been positively reviewed,
so I'm switching the whole ticket to `positive review`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4376#comment:17>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
