#10776: poset top() function breaks when top element has boolean value False
-----------------------------+----------------------------------------------
   Reporter:  niles          |       Owner:  sage-combinat       
       Type:  defect         |      Status:  needs_review        
   Priority:  major          |   Milestone:  sage-4.7            
  Component:  combinatorics  |    Keywords:  beginner, poset, top
     Author:  Niles Johnson  |    Upstream:  N/A                 
   Reviewer:                 |      Merged:                      
Work_issues:                 |  
-----------------------------+----------------------------------------------

Comment(by novoselt):

 The fifth bullet in
 http://sagemath.org/doc/developer/trac.html#section-review-patches

 I don't have a strong opinion on it and was only mentioning it since it is
 required. (I have also realized that I never marked such doctests with the
 '''inline comment''' and I am pretty sure not all bugs that I have
 reviewed used them...)

 As for meaningless references, perhaps it isn't very relevant since most
 of such "marked" tests should go into TESTS section and not EXAMPLES, so
 only developers will look at them. On the other hand, I didn't ever have a
 need to follow these references. But that may be because I am not a
 sufficiently active developer ;-)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10776#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to