#10761: Numerical approximation of an algebraic number raises a ValueError
----------------------------+-----------------------------------------------
   Reporter:  slabbe        |       Owner:  tbd                              
       Type:  defect        |      Status:  needs_review                     
   Priority:  major         |   Milestone:  sage-4.7                         
  Component:  numerical     |    Keywords:  numerical_approx, AlgebraicNumber
     Author:  Simon Spicer  |    Upstream:  N/A                              
   Reviewer:                |      Merged:                                   
Work_issues:                |  
----------------------------+-----------------------------------------------

Comment(by spice):

 Hi Rob

 On the issues you've raised:

 1) `type(E[1])` changed to `E[1].parent()` in the example as per your
 suggestion.

 2) Regarding the naked except clause, I tried to add a catch of
 `ValueError`, but the function was still breaking. I wasn't able to figure
 out why, which is why I defaulted to catching everything. I figured this
 was okay, though, since this was just one part of a multistep coercion
 attempt - and thus errors are to be expected. Thoughts?

 3) Inline comment streamlined to a single line.

 Simon

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10761#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to