#10469: Don't (effectively) source sage-env more than once
---------------------------+------------------------------------------------
   Reporter:  leif         |       Owner:  GeorgSWeber                          
  
       Type:  defect       |      Status:  needs_review                         
  
   Priority:  major        |   Milestone:  sage-4.7                             
  
  Component:  build        |    Keywords:  environment variables sage-sage 
scripts
     Author:  Ivan Andrus  |    Upstream:  N/A                                  
  
   Reviewer:               |      Merged:                                       
  
Work_issues:               |  
---------------------------+------------------------------------------------

Comment(by jhpalmieri):

 Replying to [comment:5 iandrus]:
 > What is the purpose of checking `SAGE_ROOT` but not doing anything with
 it?  Is it just so that it prints a warning?  It seems that if `sage-env`
 has been sourced `SAGE_ROOT` should be set correctly.

 You're probably right, and if this is always called via a call to sage,
 this could probably be deleted.  As it stands, the changes here look
 pretty safe to me, but removing that check seems a bit riskier, and
 something which would require more serious testing.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10469#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to