#8473: Make .sws files clickable
---------------------------------------------------------------------+------
Reporter: olazo |
Owner: iandrus
Type: enhancement |
Status: needs_work
Priority: minor |
Milestone: sage-4.7
Component: notebook |
Keywords:
Author: Ivan Andrus |
Upstream: N/A
Reviewer: Karl-Dieter Crisman |
Merged:
Work_issues: document option, only require login when it should be |
---------------------------------------------------------------------+------
Comment(by iandrus):
Replying to [comment:13 kcrisman]:
> I can taste it now that you reviewed #693. This is great stuff, good
work.
:-)
> Okay, needs work because this option isn't documented. Ordinarily I
wouldn't be as strict with NB stuff because so little of it is documented
anyway, but I think it is key that `notebook?` tells us what happens.
Good point. I have added documentation for `notebook?`. Does it need
documentation in `sage --advanced` as well?
> I also have a couple questions, but they just indicate my lack of
knowledge.
> * I don't understand this change. More precisely, we now have the
default `startpath = ''`, but that isn't the same as `\`. Will that
matter somewhere for non-uploading situations?
> {{{
> browse_to(old_interface, old_port, old_secure,
'/')
> browse_to(old_interface, old_port, old_secure,
startpath)
> }}}
I don't think that should matter, but I changed it to `'/'` since it makes
more sense. In an earlier version of the patch I think I appended to
`startpath` and that's why it was empty.
> * You said you added something to fix special character issues, but I
don't know where that is, other than the place where you import urllib -
but you only do that in the case that someone needs to log in. Is that
the only place it's needed? This could just be my ignorance speaking.
You are right, there was a bug there. I need it both places. Thanks.
> * Looks like file names with spaces have to be escaped with the syntax
`./sage -n /path/to/work\ sheet.sws'
Yes. They have to be escaped for the shell so that they appear as one
argument. That's the same as any argument to `sage -n`. However, I
should point out that the syntax is `sage -n upload="/path/to work
sheet.sws"`. I guess that's why we need documentation, eh? :-)
> * I also discovered what might be a bug, or maybe it's a feature...
trying to upload a file via `./sage -n /path/to/sws.sws` asks for a new
password for admin. That is really annoying, esp. if this is only
supposed to work on a local machine anyway!
I think what's happening here is it's starting a new notebook server with
/path/to/sws.sws as it's directory or something. I think that's why it's
asking for a password.
> I'd be inclined to separate the new notebook functionality from adding
clickable sws files to the Sage App, for review purposes but also because
this would have to be part of a new SageNB package, and it would be nice
to separate those things out. The logistics are already complicated
enough for things.
That's probably a good idea. I'll split the extcode off into another
ticket.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8473#comment:15>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
