#4120: New code for binary quadratic forms
------------------------------------------------------------------------+---
Reporter: justin |
Owner: justin
Type: enhancement |
Status: needs_work
Priority: major |
Milestone: sage-4.7
Component: quadratic forms |
Keywords:
Author: Justin Walker, Jon Hanke, Gonzalo Tornaria, John Cremona |
Upstream: N/A
Reviewer: John Cremona |
Merged:
Work_issues: |
------------------------------------------------------------------------+---
Changes (by newvalueoldvalue):
* status: needs_review => needs_work
* reviewer: => John Cremona
* author: => Justin Walker, Jon Hanke, Gonzalo Tornaria, John Cremona
Comment:
Patch applies and tests pass.
My only suggestion is that for invalid input you should raise an
appropriate error (ValueError) rather than printing something and
returning []. And all integers =0,1(mod 4) should be allowed, even
squares? The docstring should specify exactly what valid inputs are, in
any case.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/4120#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
