#8614: Optimize creation of modular symbols spaces by speeding up quotienting
out
by 2-term relations
---------------------------------------------------------+------------------
Reporter: was | Owner:
craigcitro
Type: enhancement | Status:
positive_review
Priority: major | Milestone:
sage-4.7
Component: modular forms | Keywords:
Author: William Stein | Upstream: N/A
Reviewer: Alex Ghitsa, David Loeffler, John Cremona | Merged:
Work_issues: |
---------------------------------------------------------+------------------
Changes (by newvalueoldvalue):
* status: needs_review => positive_review
* reviewer: => Alex Ghitsa, David Loeffler, John Cremona
* author: => William Stein
Comment:
Replying to [comment:11 cremona]:
> The patch looks good to me (applied to 4.7.alpha2) and I am testing now,
by testing whether ModularSymbols(N) and CremonaModularSymbols(N) have the
same dimension for N up to {{{10^4}}}. And some more.
{{{
sage: time a=[CremonaModularSymbols(N).dimension() for N in [1000..2000]]
CPU times: user 31.12 s, sys: 0.52 s, total: 31.64 s
Wall time: 31.68 s
sage: time b=[ModularSymbols(N).dimension() for N in [1000..2000]]
CPU times: user 636.90 s, sys: 0.14 s, total: 637.04 s
Wall time: 637.91 s
sage: a==b
True
}}}
This is enough to convince me that the implementation is ok. I tested the
complete library too.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/8614#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
