#11052: Bad shell logic in root-spkg-install
------------------------------+---------------------------------------------
Reporter: jdemeyer | Owner:
Type: defect | Status: new
Priority: critical | Milestone: sage-4.7
Component: scripts | Keywords: sage_root
Author: Jeroen Demeyer | Upstream: N/A
Reviewer: | Merged:
Work_issues: |
------------------------------+---------------------------------------------
The following piece of `root-spkg-install` doesn't work as intented,
because the `$?` refers to the exit status of the first `if` instead of
`hg incoming`:
{{{
# Merge the repository, rather than overwrite changes that the
# user may have made.
hg incoming "$CUR" 1> /dev/null
if [ $? -eq 1 ]; then
# No changes to pull
exit 0
fi
if [ $? -ne 0 ]; then
echo "Error with Sage root repository: 'hg incoming' failed."
exit 1
fi
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11052>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
