#11070: Update prereq so that SAGE_PORT does not need setting on Solaris x86
----------------------------+-----------------------------------------------
   Reporter:  drkirkby      |       Owner:  drkirkby    
       Type:  defect        |      Status:  needs_review
   Priority:  major         |   Milestone:  sage-4.7    
  Component:  solaris       |    Keywords:              
     Author:  David Kirkby  |    Upstream:  N/A         
   Reviewer:                |      Merged:              
Work_issues:                |  
----------------------------+-----------------------------------------------

Comment(by jhpalmieri):

 Hi Dave,

 In principle this looks good.  One very minor change to the patch: add a
 period at the end of
 {{{
 echo "Sage is not supported on any version of Solaris earlier than 10"
 }}}
 (You're deleting the following line, which has the period for that
 sentence.)

 More importantly, though, I think that the file prereq-0.8-install should
 be added to the spkg/base repo, it should be executable, and
 prereq-0.7-install should be removed from the repo.  (I guess actually you
 should use hg to rename the 0.7 version to the 0.8 version, and then patch
 it.)  The .hgignore file should be modified, too, to include the new tar
 file, and I suppose it doesn't need to mention the old tar file.

 I'm attaching a mercurial patch which does these things, and I've
 committed it in your name.  Let me know if you have any objections.
 Please take a look at the patch, and if you're happy with it, give the
 ticket a positive review.  (I'm happy with your changes, I just want to
 make sure you're happy with my implementation of them.)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11070#comment:6>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to