#9944: categories for polynomial rings
-----------------------------------------------------------+----------------
Reporter: robertwb | Owner:
nthiery
Type: defect | Status:
positive_review
Priority: major | Milestone:
sage-4.7
Component: categories | Keywords:
Author: Robert Bradshaw, Simon King | Upstream: N/A
Reviewer: Nicolas M. Thiéry, Mike Hansen, Martin Raum | Merged:
Work_issues: |
-----------------------------------------------------------+----------------
Changes (by mraum):
* status: needs_review => positive_review
* reviewer: Nicolas M. Thiéry, Mike Hansen => Nicolas M. Thiéry, Mike
Hansen, Martin Raum
Comment:
The speed up is significant and all tests pass. This gets a positive
review.
Let me point out the following (that won't show up in many use case, but
still might deserve some consideration later):
unpatched:
{{{
sage: R = PolynomialRing(ZZ, ['a' + str(n) for n in range(10000)])
sage: x = R.gen(0)
sage: timeit('(2*x - 1)^2 + 5', number = 10^4)
10000 loops, best of 3: 94.5 µs per loop
}}}
patched:
{{{
sage: R = PolynomialRing(ZZ, ['a' + str(n) for n in range(10000)])
sage: x = R.gen(0)
sage: timeit('(2*x - 1)^2 + 5', number = 10^4)
10000 loops, best of 3: 131 µs per loop
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9944#comment:27>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
