#10998: Categories for posets
---------------------------------------------------------------------+------
Reporter: nthiery |
Owner: sage-combinat
Type: enhancement |
Status: needs_review
Priority: major |
Milestone: sage-5.0
Component: combinatorics |
Keywords:
Author: Frédéric Chapoton, Christian Stump, Nicolas M. Thiéry |
Upstream: N/A
Reviewer: |
Merged:
Work_issues: |
---------------------------------------------------------------------+------
Comment(by nthiery):
Replying to [comment:7 stumpc5]:
> I must say: there is a lot of code where I don't really understand
> what you do, and why you do it.
Hmm, more specific questions (like the one below) would be useful to
get a constructive discussion :-)
> E.g., which code is generic enough to put in categories and which is
> not,
The rule of thumb is: does the code use the data structure or not?
For example, a method like has_top uses the internal hasse diagram,
and therefore remains in Poset. On the other hand a method like
join_irreducibles just requires that there is a method "lower_covers",
and so can be implemented generically in the category.
But that's just a rule thumb; I left in Poset all the code that was on
the edge, so as to avoid moving too much code around.
> how are examples organized, how do you properly test the code, ...
Are those questions about the category framework in general, or about
this specific patch?
> In my (not yet final) review patch, I place some questions on
> implementations, some suggestions for additional methods, and I
> fixed several typos.
Ok, thanks!
Cheers,
Nicolas
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10998#comment:8>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
