#9109: Fast cython class for maps between finite sets.
----------------------------------------------+-----------------------------
Reporter: hivert | Owner: hivert
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: combinatorics | Keywords: finite sets map
Author: Florent Hivert | Upstream: N/A
Reviewer: Mike Hansen, Nicolas M. Thiéry | Merged:
Work_issues: |
----------------------------------------------+-----------------------------
Comment(by hivert):
> Florent: please check the small reviewer patch on the Sage-Combinat
> queue. If the changes are ok with you, you can fold/upload and set a
> positive review on my behalf.
Hi Nicolas ! Thanks a lot for the numerous English corrections. The doc is
much better now ! I'm perfectly ok with all your changes, except for the
following wrong ReST markup:
{{{
diff --git a/sage/sets/finite_set_map_cy.pyx
b/sage/sets/finite_set_map_cy.pyx
--- a/sage/sets/finite_set_map_cy.pyx
+++ b/sage/sets/finite_set_map_cy.pyx
@@ -86,7 +86,7 @@ cpdef fibers(f, domain):
{1: {1}}
.. seealso:: :func:`fibers_args` if one needs to pass extra
- arguments to ``f``.
+ arguments to ``f``.
"""
result = {}
for x in domain:
}}}
I folded your patch and added this small change. It is a rather trivial
change
but, in order to follow the rules, someone has to look at it. So it's now
your
job to set the positive review :-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9109#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
