#9976: Decorated functions/methods have generic signature in documentation
--------------------------------+-------------------------------------------
   Reporter:  jsrn              |       Owner:  jsrn                            
        
       Type:  enhancement       |      Status:  needs_work                      
        
   Priority:  major             |   Milestone:  sage-4.7                        
        
  Component:  documentation     |    Keywords:  sphinx, documentation, cython 
inspection
     Author:  jsrn, Simon King  |    Upstream:  N/A                             
        
   Reviewer:                    |      Merged:                                  
        
Work_issues:                    |  
--------------------------------+-------------------------------------------

Comment(by SimonKing):

 Replying to [comment:106 jsrn]:
 > Cool that you're fixing a bug in SageArgSpecVisitor.
 >
 > But just to get straight here, the weird case covered in lines 730-741
 is only implemented to fix decorators like cached_method, which doesn't
 correctly set the inspection attributes (more precisely, sets their
 _sage_src_ correctly but not _sage_argspec_). But for cached_method, this
 is going to be fixed in #11115.

 Right.

 > And for other decorators (if they exist), this should also be fixed. And
 after these fixes, we will remove the code in lines 730-741?

 I don't think so. If I am not mistaken, these lines (and a similar set of
 lines in a different place) will be used in different cases as well. And
 since it is not particularly difficult to extend the functionality of the
 `SageArgSpecVisitor`, I think we should aim for sufficient generality.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9976#comment:107>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to