#11156: sage.misc.sage_unittest.InstanceTester should call its base's __init__
---------------------------------+------------------------------------------
Reporter: nthiery | Owner: mvngu
Type: defect | Status: positive_review
Priority: major | Milestone: sage-4.7
Component: doctest | Keywords: TestSuite
Author: Nicolas M. Thiéry | Upstream: N/A
Reviewer: François Bissey | Merged:
Work_issues: |
---------------------------------+------------------------------------------
Changes (by fbissey):
* status: needs_review => positive_review
Old description:
> The following patch fixes sage.misc.sage_unittest.InstanceTester to call
> it's base's __init__ as requested by the documentation of
> unittest.TestCase. This was harmless with Python 2.6, but breaks e.g.
> assertEqual with the new version of unittest in Python 2.7.
> See: http://groups.google.com/group/sage-
> devel/browse_thread/thread/e008180354a150f3
New description:
The following patch fixes sage.misc.sage_unittest.InstanceTester to call
it's base's __init__ as requested by the documentation of
unittest.TestCase. This was harmless with Python 2.6, but breaks e.g.
assertEqual with the new version of unittest in Python 2.7.
See: http://groups.google.com/group/sage-
devel/browse_thread/thread/e008180354a150f3
Apply:
* [attachment:trac_11156-sage_unittest-init-nt.patch]
--
Comment:
No side effects. I am giving this a positive review. Can we have it in 4.7
pretty please?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11156#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
