#9976: Decorated functions/methods have generic signature in documentation
-----------------------------------------------------+----------------------
Reporter: jsrn | Owner: jsrn
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.7
Component: documentation | Keywords: sphinx,
documentation, cython inspection
Author: jsrn, Simon King | Upstream: N/A
Reviewer: Simon King | Merged:
Work_issues: Cosmetical changes, indirect doctests |
-----------------------------------------------------+----------------------
Comment(by jsrn):
Replying to [comment:120 SimonKing]:
> So, it could really be that it has nothing to do with our patches.
I'm afraid it must have (though I don't know how): I popped all three
patches, rebuilt (./sage -b), deleted doc/output, and rebuilt
documentation (./sage -docbuild reference html). No warnings. Then a
reapplied all three patches, rebuilt, delete doc/output, rebuilt
documentation: all the mentioned warnings
:-(((
> By the way, I slightly lost track: Did you provide indirect doctests for
your patch, exhibiting the way _sage_argspec is supposed to be used? It
would also be possible that I do, by a reviewer patch.
Yes I changed the old doctests to use sage_getargspec, though I did not
flag them as #indirect doctest. As I wrote in comment 117, I don't
understand why that flag needs to be used.
> Concerning review: It seems that sage-devel gave us permission that I
review your patch and you review mine - provided that we honestly think we
are non-biased with respect to the other person's patch.
Yes, I saw that and I agree. I think we have been appropriately critical
and meticulous about each other's patches ;-)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9976#comment:121>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
