#11138: Make Jacobi symbol
----------------------------------------------------+-----------------------
Reporter: kcrisman | Owner: was
Type: enhancement | Status: needs_work
Priority: minor | Milestone:
Component: number theory | Keywords: beginner
Author: Taylor Dupuy | Upstream: N/A
Reviewer: François Bissey, Karl-Dieter Crisman | Merged:
Work_issues: |
----------------------------------------------------+-----------------------
Changes (by newvalueoldvalue):
* status: new => needs_work
* reviewer: => François Bissey, Karl-Dieter Crisman
* author: => Taylor Dupuy
Comment:
Thanks for your efforts, Taylor!
There are some things that should be done for this patch to pass muster.
* You definitely need more doctests. There are lots of models in this
same file as models. I would use the model of `legendre_symbol`, since it
tests for catching illegal input.
* Your formatting is off. Check the docs for `kronecker_symbol` to see
'exactly' how things like examples and input should be formatted.
* I'm not sure why you don't just pass to `kronecker_symbol`, which is
optimized, after catching the invalid input.
* Math should be in single ticks.
{{{
n = p1^e1 * ... * pr^er then (a|n) = (a|p1)^e1 ... (a|pr)^er where (a|pj)
}}}
versus
{{{
`n = p1^e1 * ... * pr^er` then `(a|n) = (a|p1)^e1 ... (a|pr)^er` where
`(a|pj)`
}}}
for the formatting in documentation. You may also need to do
{{{p_1^{e_1}}}} in order for it to look right - try `./sage -docbuild
reference html` to see what happens.
Again, thanks for helping make Sage even better!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11138#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
