#9960: require SAGE_CHECK to be "yes"
---------------------------------------------------------+------------------
Reporter: jhpalmieri | Owner: was
Type: defect | Status:
positive_review
Priority: major | Milestone:
sage-4.7.1
Component: user interface | Keywords:
Author: John Palmieri, Leif Leonhardy | Upstream: N/A
Reviewer: Leif Leonhardy, Ivan Andrus, David Kirkby | Merged:
Work_issues: |
---------------------------------------------------------+------------------
Old description:
> Right now, setting SAGE_CHECK to any nonempty string (e.g., "no") runs
> the test suite. The documentation actually says that SAGE_CHECK should
> be "yes" for this to happen. Fix this.
>
> While we're at it, fix something else: in the script SAGE_ROOT/local/bin
> /sage-env, SAGE64 is required to be "yes", "no", or unset:
> {{{
> if [ "$SAGE64" != "yes" -a "$SAGE64" != "no" ]; then
> echo "The environment variable SAGE64 (=$SAGE64) must be either
> unset, yes or no."
> exit 1
> fi
> }}}
> The problem is, whenever sage-env is run, output is redirected to
> /dev/null, so this error message isn't printed. So for example:
> {{{
> $ export SAGE64='maybe'
> $ sage
> $
> }}}
> Sage fails to run and is completely silent as to why. Fix this, too.
>
> ----
>
> Also, due to a bug in `sage-spkg`, successful test suite runs never get
> logged in `spkg/installed/<package-name>` as they should (or is
> intended); this is fixed by the reviewer patch.
>
> (Note that test suite '''failures''' cannot be logged in these files as
> they get deleted on non-successful builds, which [currently] includes
> successful builds with failing self-tests.)
>
> -----
>
> Apply only [attachment:trac_9960-scripts-SAGE_CHECK.v2.patch] (to the
> scripts repo).
>
> Depends on #11073.
New description:
Right now, setting SAGE_CHECK to any nonempty string (e.g., "no") runs the
test suite. The documentation actually says that SAGE_CHECK should be
"yes" for this to happen. Fix this.
While we're at it, fix something else: in the script SAGE_ROOT/local/bin
/sage-env, SAGE64 is required to be "yes", "no", or unset:
{{{
if [ "$SAGE64" != "yes" -a "$SAGE64" != "no" ]; then
echo "The environment variable SAGE64 (=$SAGE64) must be either unset,
yes or no."
exit 1
fi
}}}
The problem is, whenever sage-env is run, output is redirected to
/dev/null, so this error message isn't printed. So for example:
{{{
$ export SAGE64='maybe'
$ sage
$
}}}
Sage fails to run and is completely silent as to why. Fix this, too.
----
Also, due to a bug in `sage-spkg`, successful test suite runs never get
logged in `spkg/installed/<package-name>` as they should (or is intended);
this is fixed by the reviewer patch.
(Note that test suite '''failures''' cannot be logged in these files as
they get deleted on non-successful builds, which [currently] includes
successful builds with failing self-tests.)
-----
Apply only [attachment:trac_9960-scripts-SAGE_CHECK.v2.patch] (to the
scripts repo).
Depends on either #11073 or running "sage -sdist" to make a new
distribution.
--
Comment(by jhpalmieri):
I'm concerned that #11073 is going to be complicated: it will touch files
in the scripts repo, in the root repo, and (of course) in the base repo.
I'm not even sure what the right approach is for that ticket. I'll post
some questions there.
The fixes in #9960 and #11008 are pretty tame, comparatively. I think you
can just apply the patches on those two tickets and then run "sage -sdist"
to make a new source distribution; that should move the changed files to
spkg/base. So I would ''prefer'' that you merge those two. But I'm not
going to ''insist''; you're the release manager, so if it makes your job
much easier to wait, then wait.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9960#comment:63>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
