#11181: edge labels should be unique
----------------------------------------------+-----------------------------
Reporter: rlm | Owner: jason, ncohen, rlm
Type: defect | Status: needs_review
Priority: major | Milestone: sage-4.7
Component: graph theory | Keywords:
Author: Robert Miller | Upstream: N/A
Reviewer: Nathann Cohen, Christian Stump | Merged:
Work_issues: |
----------------------------------------------+-----------------------------
Changes (by stumpc5):
* reviewer: Christian Stump => Nathann Cohen, Christian Stump
Comment:
Salut,
to me, the patch and the review patch look fine! Thanks for the work.
One minor thing:
The code for iterator_edges, iterator_in_edges, and iterator_out_edges
looks like most of it is redundant. Also, I don't understand why the
multiple edges are not important in iterator_edges but is checked in both
others.
Best, Christian
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11181#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
