#10966: Make it impossible for unprivileged trac users to close tickets
----------------------------+-----------------------------------------------
Reporter: mderickx | Owner: mvngu, schilly
Type: enhancement | Status: positive_review
Priority: major | Milestone:
Component: website/wiki | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Keshav Kini | Author: Maarten Derickx
Merged: | Dependencies:
----------------------------+-----------------------------------------------
Changes (by kini):
* status: needs_review => positive_review
* reviewer: => Keshav Kini
Old description:
> In several places in the documentation it says you shouldn't
> close [[BR]]tickets if you have never done the release
> management. [[BR]]Since it's so trivial to fix maybe we should change the
> needed rights [[BR]]to change the [[BR]]status to prevent someone
> unknowing to close a ticket. According
> to [[BR]][http://www.google.com/url?sa=D&q=http://trac.edgewall.org/wiki/TracWorkflow
> http://trac.edgewall.org/wiki/TracWorkflow] this [[BR]]can be done by
> changing:
>
> close.permissions = TICKET_MODIFY
>
> into
>
> close.permissions = TICKET_ADMIN
>
> in the trac.ini file. Offcourse TICKET_ADMIN could be anything
> logical [[BR]]from [http://www.google.com/url?sa=D&q=http://trac.edgewall.org/wiki/TracPermissions
> http://trac.edgewall.org/wiki/TracPermissions]
>
> ps. we could even do more fancy stuff like add a "nominate
> for [[BR]]closure" status to the workflow or a "request patchbot" and
> a [[BR]]"patchbot doctest passed" depending on how the developement
> workflow [[BR]]in real life.
New description:
In several places in the documentation it says you shouldn't close tickets
if you aren't a release manager. Since it's so trivial to fix maybe we
should change the rights needed to change the status of a ticket in order
to prevent unknown people from closing tickets. According to
[http://trac.edgewall.org/wiki/TracWorkflow the trac wiki] this can be
done by changing `close.permissions = TICKET_MODIFY` to `close.permissions
= TICKET_ADMIN` in the `trac.ini` file. Of course `TICKET_ADMIN` could be
anything logical from [http://trac.edgewall.org/wiki/TracPermissions the
possible permission set].
We could even do more fancy stuff like add a "nominate for closure" status
to the workflow or a "request patchbot" and a "patchbot doctest passed"
depending on how the development workflow is in real life.
--
Comment:
Looks good. I can't close tickets, and the documentation builds fine. I
successfully added a dependency to #11120. Positive review!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10966#comment:5>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
