#10859: Add is_series() method and others to symbolic expressions
-----------------------------------+----------------------------------------
Reporter: vbraun | Owner: burcin
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.7
Component: symbolics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Karl-Dieter Crisman | Author: Volker Braun
Merged: | Dependencies:
-----------------------------------+----------------------------------------
Changes (by kcrisman):
* status: needs_review => needs_work
* reviewer: => Karl-Dieter Crisman
Comment:
A few comments/questions:
* Are there any other symbolic objects that would look like series but
not be caught by this? (For instance, ones gotten by doing {{{SR(some
Maxima thing that returns a series)}}}.) I guess I'm wondering if this is
only supposed to find things created by `.series()` or if it's supposed to
catch anything that's a series.
* Does this include Laurent series?
* There are a couple weird typos, including {{{via the :meth:`series`
method.a }}}
* The {{{Boolean. Whether ``self`` was constructed by :meth:`series`.}}}
should look more like it does for other outputs, or at least have a
semicolon or colon or something for both of these functions.
* I think that the second patch should be part of a separate ticket.
Presumably someone thought it was good for the methods to be hidden, so it
would be helpful to know why that is.
* Should we maybe even discuss whether these new methods should be
underscored?
I apologize for not having time to give this a proper review, though on a
cursory examination it looks fine in terms of the actual code and tests.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10859#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
