#11257: Avoid a coercion when computing an element to the power of 0
---------------------------+------------------------------------------------
   Reporter:  nborie       |          Owner:  nborie                        
       Type:  enhancement  |         Status:  needs_review                  
   Priority:  major        |      Milestone:  sage-4.7.1                    
  Component:  performance  |       Keywords:  coercion, element, power, zero
Work_issues:               |       Upstream:  N/A                           
   Reviewer:               |         Author:  Nicolas Borie                 
     Merged:               |   Dependencies:                                
---------------------------+------------------------------------------------

Comment(by nthiery):

 Replying to [comment:8 nborie]:
 > I tried to do the best... Fix the TestSuite on old parents is not a
 simple job. Especially when one doesn't know enough about old category
 system... I fix properly the categories of affected parents, but I do not
 know how to do for the elements (especially when there is some facade with
 a separate implementation of the elements).
 >
 > (((
 > sage: w = SymmetricGroup(2)([2,1])
 > sage: G = ArithmeticSubgroup_Permutation(w, w)
 > sage: G.category()
 > Category of facade groups
 > sage: TestSuite(G).run(skip=['_test_elements'])
 > )))
 >
 > I think I passed already a lot of time on these parents (major part of
 today of trying to understand what they represent mathematically
 speaking...). Especially for the FreeMonoid feature. In the new category
 framework, the example of monoid (i.e. "Monoids().example()") is the free
 monoid. And the one coming from the category framework inherit of a LOT of
 top level methods. I try to fix FreeMonoidElement in sage/monoid with
 categories but if the choice was mine, I would just overwrite the 2005
 version with these coming from category...
 >
 > Hoping the patchbot will be happy this time! The patch does already much
 more than the ticket!

 Oops, this is going far beyond what I expected! I just meant to add
 TestSuite, and skip tests not related to zero / one. Now, this is not
 wasted time, so thanks! One should just be careful that this does not
 overlap with changes by Simon.

 Cheers,
                                 Nicolas

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11257#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to