#10334: miscellaneous cleanup in perm_gps preparing for domains
-----------------------------+----------------------------------------------
Reporter: mhansen | Owner: joyner
Type: enhancement | Status: needs_work
Priority: minor | Milestone: sage-4.7
Component: group theory | Resolution:
Keywords: | Work_issues:
Upstream: N/A | Reviewer: Robert Miller
Author: Mike Hansen | Merged:
Dependencies: |
-----------------------------+----------------------------------------------
Old description:
> '''Apply''':
> 1. [attachment:trac_10334-permgroup_cleanup-mh.patch]
New description:
'''Apply''':
1. [attachment:trac_10334-permgroup_cleanup-rebase-mh.patch]
--
Comment(by rbeezer):
On 4.7.rc0.
1) 3 hunk failures when applying {{{trac_10334-permgroup_cleanup-rebase-
mh.patch}}}, a rebase is attached.
2) With rebase a quotient group fails in a doctest. Here's the evidence:
Clean 4.7.rc0:
{{{
G = DihedralGroup(20)
C = G.commutator()
Q = G.quotient(C)
Q.is_abelian()
}}}
4.7.rc0 with rebased patch:
{{{
sage: G = DihedralGroup(20)
sage: C = G.commutator()
sage: Q = G.quotient(C)
---------------------------------------------------------------------------
TypeError Traceback (most recent call
last)
/home/sage/sage-4.7.rc0/devel/sage-main/<ipython console> in <module>()
/sage/sage-4.7.rc0/local/lib/python2.6/site-
packages/sage/groups/perm_gps/permgroup.pyc in quotient(self, N)
1483 phi = Q.RegularActionHomomorphism()
1484 gens = phi.Image().GeneratorsOfGroup()
-> 1485 return PermutationGroup([self(gen) for gen in gens])
1486
1487 def quotient_group(self, N):
/sage/sage-4.7.rc0/local/lib/python2.6/site-
packages/sage/groups/perm_gps/permgroup.pyc in __call__(self, x, check)
593 return self.identity()
594
--> 595 return self._element_class()(x, self, check=check)
596
597 def _coerce_impl(self, x):
/sage/sage-4.7.rc0/local/lib/python2.6/site-
packages/sage/groups/perm_gps/permgroup_element.so in
sage.groups.perm_gps.permgroup_element.PermutationGroupElement.__init__
(sage/groups/perm_gps/permgroup_element.c:3008)()
TypeError: permutation (1, 2)(3, 4) not in Dihedral group of order 40 as a
permutation group
}}}
I've tried to locate the error, with no luck. My rebase could be at
fault, but I've double-checked that as well.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10334#comment:19>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
