#11293: All relations of a poset
------------------------------------------+---------------------------------
   Reporter:  rbeezer                     |          Owner:  sage-combinat      
       
       Type:  enhancement                 |         Status:  needs_review       
       
   Priority:  minor                       |      Milestone:  sage-4.7.1         
       
  Component:  combinatorics               |       Keywords:  beginner           
       
Work_issues:                              |       Upstream:  N/A                
       
   Reviewer:  Franco Saliola, Rob Beezer  |         Author:  Rob Beezer, Franco 
Saliola
     Merged:                              |   Dependencies:                     
       
------------------------------------------+---------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => Franco Saliola, Rob Beezer
  * author:  Rob Beezer => Rob Beezer, Franco Saliola


Old description:

> This adds methods for posets to create an iterator and a list, for all
> the relations of the poset (not just the cover relations).
>
> '''Apply:'''
>   1. [attachment:trac_11293-all-relations-poset.patch]

New description:

 This adds methods for posets to create an iterator and a list, for all the
 relations of the poset (not just the cover relations).

 '''Apply:'''
   1. [attachment:trac_11293-all-relations-poset-v2.patch]

--

Comment:

 Franco's reviewer patch looks real good.  So positive review on that part
 from me.

 Franco also mentioned that we need to include the "diagonal relation", so
 the inner loop index has been adjusted to make that happen, and doctests
 updated.  Then I rolled up the original patch, the reviewer patch, and the
 "diagonal" changes all into a single v2 patch.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11293#comment:3>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to