#10530: De Bruijn Sequence construction for combinat
---------------------------------+------------------------------------------
Reporter: eviatarbach | Owner: eviatarbach
Type: enhancement | Status: needs_info
Priority: major | Milestone: sage-4.7
Component: combinatorics | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Nicolas M. Thiéry | Author: Eviatar Bach
Merged: | Dependencies:
---------------------------------+------------------------------------------
Changes (by ncohen):
* status: needs_review => needs_info
Comment:
I haven't been able to check the documentation was correctly geenrated,
something's wrong with my Sage install and I should be able to do that
tomorrow. Meanwhile, I wrote a patch which does the following :
* Add some documentation and examples at the top of DeBruijn_sequences
file, to illustrate what it does
* Wrote a is_debruijn_sequence to test the correctness of the answers
given
* Wrote a __contains__ method in the DeBruijn_Sequences class
* Fixed several docstrings on the following point : an object of the
class DeBruijnSequences represents ALL the DeBruijn Sequences, even though
its main point for now is to be able to generate them. For instance, the
documentation sometimes implied that such an object *was* a DeBruijn
sequence.
* The current implementation returned sequences of length 0 when k =
0, regardless of the value of n. In this patch it returns [0] * n. Do we
agree on that ?
* The "references" field did not follow the good syntax
* The cardinality formula was wrong
I also wondered whether there was any reason to have two files instead of
one. What about just having a debruijn_sequences.pyx with everything
inside, instead of two files ?
Nathann
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10530#comment:23>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
