#9944: categories for polynomial rings
--------------------------------------------+-------------------------------
Reporter: robertwb | Owner: nthiery
Type: defect | Status: needs_work
Priority: major | Milestone: sage-4.7.1
Component: categories | Resolution:
Keywords: | Work_issues:
Upstream: N/A | Reviewer: Nicolas M.
Thiéry, Mike Hansen, Martin Raum
Author: Robert Bradshaw, Simon King | Merged:
Dependencies: sage-4.7 + #11139 |
--------------------------------------------+-------------------------------
Changes (by SimonKing):
* status: positive_review => needs_work
Old description:
> Currently, they're always just commutative rings.
>
> '''Apply:'''
> 1. [attachment:9944-poly-cat.patch]
> 2. [attachment:trac-9944-poly_cat_doctests.patch]
> 3. [attachment:trac-9944-poly-cat-review.patch]
> 4. [attachment:trac-9944-polynomial_speedup.patch]
> 5. [attachment:trac9944_abvar_endomorphism.patch]
> 6. [attachment:trac9944_faster_and_cleaner_coercion.2.patch]
>
> '''Note'''
>
> The same result can be obtained with the original patches:
> 1. [attachment:9944-poly-cat.patch]
> 2. [attachment:trac-9944-poly_cat_doctests.patch]
> 3. [attachment:trac-9944-poly-cat-review.patch]
> 4. [attachment:trac9944_polynomial_speedup.patch] (Note the name
> difference to 4. above)
> 5. [attachment:trac9944_abvar_endomorphism.patch]
> 6. [attachment:trac9944_faster_and_cleaner_coercion.patch] (Note the
> name difference to 6. above)
New description:
Currently, they're always just commutative rings.
'''Apply:'''
1. [attachment:9944-poly-cat.patch]
2. [attachment:trac-9944-poly_cat_doctests.patch]
3. [attachment:trac-9944-poly-cat-review.patch]
4. [attachment:trac-9944-polynomial_speedup.patch]
5. [attachment:trac9944_abvar_endomorphism.patch]
6. [attachment:trac9944_faster_and_cleaner_coercion.2.patch]
7. [attachment:trac9944_addendum.patch] (needs review)
'''Note'''
The same result can be obtained with the original patches:
1. [attachment:9944-poly-cat.patch]
2. [attachment:trac-9944-poly_cat_doctests.patch]
3. [attachment:trac-9944-poly-cat-review.patch]
4. [attachment:trac9944_polynomial_speedup.patch] (Note the name
difference to 4. above)
5. [attachment:trac9944_abvar_endomorphism.patch]
6. [attachment:trac9944_faster_and_cleaner_coercion.patch] (Note the
name difference to 6. above)
7. [attachment:trac9944_addendum.patch] (needs review)
--
Comment:
I hope it is OK that I modified one test in
sage.rings.polynomial.polynomial_ring, by the new patch
[attachment:trac9944_addendum.patch].
That test used to be
{{{
sage: QQ['y'] < QQ['x']
False
sage: QQ['y'] < QQ['z']
True
}}}
But that is unsafe, because this ticket removes the custom `__cmp__`
method of polynomial rings. So, the comparison relies on virtually random
data such as `id(QQ['x'])`, if I am not mistaken.
Therefore, it seems safer to me to replace it by
{{{
sage: QQ['y'] != QQ['x']
True
sage: QQ['y'] != QQ['z']
True
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9944#comment:94>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
