#10140: Base sage.geometry.cone on the Parma Polyhedra Library (PPL)
-------------------------------------------------+--------------------------
    Reporter:  vbraun                            |         Owner:  mhampton     
                   
        Type:  enhancement                       |        Status:  closed       
                   
    Priority:  major                             |     Milestone:  sage-4.7.1   
                   
   Component:  geometry                          |    Resolution:  fixed        
                   
    Keywords:  ppl                               |   Work_issues:               
                   
    Upstream:  N/A                               |      Reviewer:  Andrey 
Novoseltsev, Volker Braun
      Author:  Volker Braun, Andrey Novoseltsev  |        Merged:  
sage-4.7.1.alpha1               
Dependencies:  #10039                            |  
-------------------------------------------------+--------------------------

Old description:

> As a first useful application of the PPL Cython library interface I have
> changed `sage.geometry.cone.Cone` to use the PPL wrapper instead of
> `cddlib`. Here is a quick benchmark with a fan that was somewhat
> challenging:
> {{{
> sage: from sage.schemes.generic.toric_variety_library import
> toric_varieties_rays_cones
> sage: rays, cones = toric_varieties_rays_cones['BCdlOG']
> sage: timeit('Fan(cones,rays)')
> 5 loops, best of 3: 1.95 s per loop
> }}}
> With the old `Polyhedron`/`cddlib` interface, I got instead
> {{{
> 5 loops, best of 3: 42.1 s per loop
> }}}
>
> '''Apply'''
>  1. [attachment:trac_10140_sublattice_intersection.patch]
>  1. [attachment:trac_10140_base_cone_on_ppl_original.patch]
>  1. [attachment:trac_10140_reviewer.patch]
>  1. [attachment:trac_10140_switch_point_containment_to_PPL.patch]

New description:

 As a first useful application of the PPL Cython library interface I have
 changed `sage.geometry.cone.Cone` to use the PPL wrapper instead of
 `cddlib`. Here is a quick benchmark with a fan that was somewhat
 challenging:
 {{{
 sage: from sage.schemes.generic.toric_variety_library import
 toric_varieties_rays_cones
 sage: rays, cones = toric_varieties_rays_cones['BCdlOG']
 sage: timeit('Fan(cones,rays)')
 5 loops, best of 3: 1.95 s per loop
 }}}
 With the old `Polyhedron`/`cddlib` interface, I got instead
 {{{
 5 loops, best of 3: 42.1 s per loop
 }}}

 '''Apply'''
  1. [attachment:trac_10140_sublattice_intersection.patch]
  1. [attachment:trac_10140_base_cone_on_ppl_original.patch]
  1. [attachment:trac_10140_reviewer.patch]
  1. [attachment:trac_10140_switch_point_containment_to_PPL.patch]


 Apply trac_10140_sublattice_intersection.patch,
 trac_10140_base_cone_on_ppl_original.patch, trac_10140_reviewer.patch,
 trac_10140_switch_point_containment_to_PPL.patch

--

Comment(by vbraun):

 I'm adding an unformatted "Apply" section in the ticket description to
 help the patch buildbot figure out the correct patches.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10140#comment:54>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to