#11385: Orbit closure as toric variety
----------------------------------+-----------------------------------------
Reporter: vbraun | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: algebraic geometry | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Andrey Novoseltsev | Author: Volker Braun
Merged: | Dependencies:
----------------------------------+-----------------------------------------
Changes (by novoselt):
* reviewer: => Andrey Novoseltsev
Comment:
Um, I don't really understand the documentation of the first (private)
function. Could you please expand/rewrite it a bit?-) In particular the
INPUT section is a bit confusing given that there are two parameters and
one of them is already called cone.
As a possible optimization
{{{
return ToricVariety(Fan(cones))
}}}
can be replaced with
{{{
return ToricVariety(Fan(discard_faces(cones), check=False))
}}}
where `discard_faces` is added to the fan module by #11200.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11385#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
