#10052: Improve the implementation of the Steenrod algebra
-----------------------------+----------------------------------------------
Reporter: jhpalmieri | Owner: AlexGhitza
Type: enhancement | Status: positive_review
Priority: major | Milestone: sage-4.7.1
Component: algebra | Keywords: steenrod, notebook
Work_issues: | Upstream: N/A
Reviewer: Niles Johnson | Author: John Palmieri
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by niles):
* status: needs_review => positive_review
Comment:
Ok, I've finally gotten back to looking at this. With the following, I'm
giving this a positive review
* The patchs apply cleanly to Sage 4.7, and pass all (long) tests for me.
* The documentation builds without warning, looks good
* Complete doctest coverage
* The previous issues I noticed (comment:8) have all been addressed, as
well as some others, and now I see no problems with the functionality
* The code is free from obvious inefficiencies (e.g. in memory
management, error handling)
* In general, this is well-written, well-documented, and a substantial
improvement!
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10052#comment:26>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
