#10519: analytic combinatorics: new code for computing asymptotics for
multivariate
generating functions
-----------------------------+----------------------------------------------
Reporter: araichev | Owner: sage-combinat
Type: enhancement | Status: needs_work
Priority: major | Milestone: sage-4.7.1
Component: combinatorics | Keywords: analytic combinatorics,
multivariate generating functions, asymptotics
Work_issues: | Upstream: N/A
Reviewer: | Author: Alex Raichev
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by slabbe):
* status: needs_review => needs_work
Comment:
Cool. I now see that a lot of the functions are now inside a class, which
looks better. So, as I said earlier, this is not really my field of study,
so I don't know how far I can go on that review. But, I can suggest at
least two things:
1. It would be better if you post a Mercurial patch instead of a Sage file
so that people can apply it and test it. Are you able to do this? Take a
look at the [http://sagemath.org/doc/developer/ Sage Developper's Guide],
where it should be explain how to create a patch.
To add your file to the documentation, you might want to look
[http://sagemath.org/doc/developer/sage_manuals.html#adding-a-new-file
here].
This winter, I gave a [http://www.liafa.jussieu.fr/~labbe/Sage/how-to-
contribute/ presentation] on How to Contribute to Sage. This may helps you
to start with Mercurial for instance.
Also, right now, I am working on #11379 where I am adding a new file to
Sage. You might find it helpfull to see how I proceed.
2. Some the [http://sagemath.org/doc/developer/conventions.html#python-
coding-conventions Python convention] are not always followed. See also
[http://www.python.org/dev/peps/pep-0008/ pep-0008]. Especially for spaces
:
{{{
Yes:
i = i + 1
No:
i= i+1
}}}
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10519#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
