#10534: Generation of subwords, subsets and set partitions
------------------------------+---------------------------------------------
   Reporter:  vdelecroix      |          Owner:  vdelecroix                     
                  
       Type:  enhancement     |         Status:  needs_review                   
                  
   Priority:  major           |      Milestone:  sage-4.7.1                     
                  
  Component:  combinatorics   |       Keywords:  generation, combinatorics, 
set, subset, partition
Work_issues:                  |       Upstream:  N/A                            
                  
   Reviewer:  Florent Hivert  |         Author:  Vincent Delecroix              
                  
     Merged:                  |   Dependencies:                                 
                  
------------------------------+---------------------------------------------
Changes (by newvalueoldvalue):

  * reviewer:  => Florent Hivert
  * author:  vdelecroix => Vincent Delecroix


Comment:

 Hi Vincent,

 Your patch looks good except a few remarks:

  - the field Author below is for credits. You should put your real name
 and
    not your login.

  - the documentation now says:
     {{{
     [...]
     The elements of the output are tuples of Python int (and not Sage
 Integer).
     [...]
     It's element are returned as plain list of python int.
     }}}
     At least one of those two sentences is wrong. Also they seems a little
     redundent. This should be fixed.

 I'm sorry for not having the time to put a review patch, nor finish the
 review
 now.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10534#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to