#10335: Add domains for permutation groups
-----------------------------+----------------------------------------------
Reporter: mhansen | Owner: joyner
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-5.0
Component: group theory | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Robert Miller | Author: Mike Hansen
Merged: | Dependencies: #10334
-----------------------------+----------------------------------------------
Comment(by nborie):
I was very close to set a positive review for this patch but I got this
faillure :
{{{
nicolas@lancelot:/opt/sage/devel/sage-combinat$ sage -t
sage/groups/perm_gps/permgroup.py
sage -t "devel/sage-combinat/sage/groups/perm_gps/permgroup.py"
**********************************************************************
File "/opt/sage/devel/sage-combinat/sage/groups/perm_gps/permgroup.py",
line 2550:
sage: G.isomorphism_to(H)
Expected:
Permutation group morphism:
From: Permutation Group with generators [(2,3), (1,2,3)]
To: Permutation Group with generators [(1,2,4), (1,4)]
Defn: [(2,3), (1,2,3)] -> [(2,4), (1,2,4)]
Got:
Permutation group morphism:
From: Permutation Group with generators [(2,3), (1,2,3)]
To: Permutation Group with generators [(1,2,4), (1,4)]
Defn: [(2,3), (1,2,3)] -> [(2,4), (1,4,2)]
**********************************************************************
1 items had failures:
1 of 9 in __main__.example_73
}}}
Is this a random test ? Is this test really unrandonized (sorry for such a
word) ?
I am running a 11.4 Ubuntu up to date on a macbook santa rosa 4,1. I got
this faillure both using the sage combinat queue and a separate branch
with only 10334 and 10335.
Also, in sage/groups/perm-gps/permgroup.py line 1119, there is still the
micro typo :
postition --> position
Anyway, It is a very very nice work and improvement of permutation groups.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10335#comment:18>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
