#11143: define symbolic functions for exponential integrals
-----------------------------+----------------------------------------------
Reporter: kcrisman | Owner: burcin
Type: defect | Status: new
Priority: major | Milestone: sage-4.7.1
Component: symbolics | Keywords: ei Ei special function maxima
Work_issues: | Upstream: N/A
Reviewer: Burcin Erocal | Author: Benjamin Jones
Merged: | Dependencies:
-----------------------------+----------------------------------------------
Changes (by newvalueoldvalue):
* reviewer: => Burcin Erocal
* milestone: => sage-4.7.1
* author: => Benjamin Jones
Comment:
The patch looks great. Thanks for the template. A few suggestions:
* The function name should be more explicit. I suggest `exp_integral_e`.
* In the top level name space `En` can be an alias for this function
(though I'd prefer not to take up a two letter name), but we should have
the long name available. It is easier to find all these functions by
`exp_integral<tab>` than `E<tab>`.
* See [http://hg.sagemath.org/sage-
main/file/tip/sage/functions/other.py#l680 _eval_ method of
sage.functions.other.Function_gamma_inc] for an example of how to find a
common parent for the arguments
* The call to mpmath does not require the prec parameter any more. If you
pass a Sage element to mpmath it handles the precision correctly. You can
delete the code for this in `_evalf_()`.
* You should remove the `__call__()` method altogether. The only purpose
of that is to display the deprecation notice. Since you are implementing a
new function here, there is nothing being deprecated.
* In `_derivative_()` the call to this function should be
`exp_integral_e(n-1, z)`, assuming you change the function name
accordingly.
I changed the ticket description to limit this to implementing symbolic
functions for exponential integrals. We can use [wiki:symbolics/functions
the wiki page] for a general overview of the progress on symbolic
functions.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11143#comment:12>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
