#9238: J. Gutow's update to Jmol in the notebook...
------------------------------------------------+---------------------------
   Reporter:  gutow                             |          Owner:  gutow        
 
       Type:  enhancement                       |         Status:  needs_review 
 
   Priority:  major                             |      Milestone:  sage-4.7.1   
 
  Component:  notebook                          |       Keywords:  sd31         
 
Work_issues:                                    |       Upstream:  N/A          
 
   Reviewer:  Jason Grout, Karl-Dieter Crisman  |         Author:  Jonathan 
Gutow
     Merged:                                    |   Dependencies:               
 
------------------------------------------------+---------------------------

Comment(by was):

 Some nitpicks with spkg-install in
 http://www.uwosh.edu/faculty_staff/gutow/Jmol_for_SageNoteBook-1.1.7.spkg

 1. Delete all the commented out code from spkg-install.  It is *not*
 comments, but code that makes no sense now.  It just makes it harder to
 read spkg-install.  The original code is in the hg history, anyways.

 2. You use "cp -v" near the bottom, but this is not POSIX compliant, e.g.,
 on Solaris we have:
 {{{
 wstein@t2:~$ touch a
 wstein@t2:~$ cp -v a b
 cp: illegal option -- v
 Usage: cp [-f] [-i] [-p] [-@] f1 f2
        cp [-f] [-i] [-p] [-@] f1 ... fn d1
        cp -r|-R [-H|-L|-P] [-f] [-i] [-p] [-@] d1 ... dn-1 dn
 }}}

 (Yep, I learned something from David Kirkby.)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/9238#comment:159>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to