#11350: Fraction fields should know whether they are finite or not.
-------------------------------+--------------------------------------------
Reporter: SimonKing | Owner: AlexGhitza
Type: enhancement | Status: needs_review
Priority: major | Milestone: sage-4.7.1
Component: algebra | Keywords: fraction field, is_finite
Work_issues: | Upstream: N/A
Reviewer: Robert Bradshaw | Author: Simon King
Merged: | Dependencies:
-------------------------------+--------------------------------------------
Changes (by SimonKing):
* status: needs_work => needs_review
Comment:
I have added a second patch.
The present test actually tests for the ''presence'' of a bug (namely an
object not knowing whether it is finite, although it should know better).
In addition, as Jeroen confirms, the test does not do what the comments
promise.
Therefore, I removed the test.
In addition, I fixed the bug mentioned above (the missing brackets aroung
`except AttributeError, NotImplementedError:`). I can not give an example
of an ''iterable'' object that does not know whether it is finite. But
still, I am able to show that I fixed the bug, because the resulting error
message shows that iteration was attempted.
Moreover, I added a note at a more prominent part of the docstring. It
says that, even though `X.list()` is often better than `list(X)`, it will
often be the case that `for x in X` is better than `for x in X.list()`.
Back to "needs review".
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11350#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
