#11558: Echelonize with transformation=True oddness for sparse matrix
------------------------------+---------------------------------------------
Reporter: vbraun | Owner: jason, was
Type: defect | Status: needs_info
Priority: major | Milestone: sage-4.7.2
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Rob Beezer | Author: Volker Braun
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by rbeezer):
* status: new => needs_info
* reviewer: => Rob Beezer
Comment:
Volker,
Unfortunate - but at least it is fixed now. Passes tests in the obvious
places, I'll run long tests overnight.
Comments, in decreasing order of merit.
1. Tests would benefit from a mention of the Trac ticket being fixed.
2. Do you want to document the `transformation` keyword in the docstring?
3. Internal logic of the echelon form code is a mystery to me, as is the
code for creating/copying matrices. Since we are both in the
neighborhood, is there a faster method for copying a matrix than the
following?
{{{
for c from 0 <= c < self.ncols():
for r from 0 <= r < self.nrows():
self.set_unsafe(r, c, d.get_unsafe(r,c))
}}}
I don't know, just seems inefficient to go entry-by-entry. Not critical,
just a thought. Long weekend here in the US, but I'll stick with this.
Rob
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11558#comment:1>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
