#11572: Add new probabillity dsitributions
---------------------------+------------------------------------------------
   Reporter:  Kamhamea     |          Owner:  amhou     
       Type:  enhancement  |         Status:  new       
   Priority:  major        |      Milestone:  sage-4.7.2
  Component:  statistics   |       Keywords:            
Work_issues:               |       Upstream:  N/A       
   Reviewer:               |         Author:  Mato Nagel
     Merged:               |   Dependencies:            
---------------------------+------------------------------------------------
Changes (by newvalueoldvalue):

  * owner:  tbd => amhou
  * type:  PLEASE CHANGE => enhancement
  * component:  PLEASE CHANGE => statistics
  * author:  => Mato Nagel


Comment:

 One minor, but important, comment - you seem to have subsumed the patch at
 #9080 in this patch.   You should instead apply that patch to your Sage,
 and then create your new patch on top of that one.   That not only makes
 it easy on the release manager, but also allows the author of the patch at
 #9080 his due credit :)

 A very minor comment - you should set up your HG defaults so that instead
 of {{{# User [email protected]}}} it gives something like {{{Mato Nagel
 <[email protected]>}}}, or something similar.  There should be something
 about this in the [http://www.sagemath.org/doc/developer/ developer
 guide].

 Also, a point of information related to your email to sage-devel; although
 you add tests for the new distributions, that wouldn't remove the need for
 #11514.  It would be a good step in that direction, though!

 ----
  More substantively, I think (my opinion only) that based on the
 [http://groups.google.com/group/sage-
 devel/browse_thread/thread/8febda1b92330c85/9cea7249b186d8e5 discussion
 about this on sage-devel], the binomial and other "discrete" distributions
 should somehow be separated, if only for user convenience.   It sounded
 from your email like this wasn't the final patch anyway, so it's not a big
 deal yet, but just recording this here for completeness.

 Thanks for taking  a stab at this!  It's certainly sorely needed - as you
 say, GSL has lots of things for us.  (So does Scipy, for that matter.)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11572#comment:2>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to