#11447: python spkg build fails on various Debian systems
---------------------------------------------------------+------------------
Reporter: pipedream | Owner:
jdemeyer
Type: defect | Status:
positive_review
Priority: blocker | Milestone:
sage-4.7.1
Component: packages | Keywords:
python spkg crypt library
Work_issues: | Upstream: N/A
Reviewer: David Kirkby, Bill Odefey, Jan Groenewald | Author: Jan
Medlock
Merged: | Dependencies:
---------------------------------------------------------+------------------
Comment(by jdemeyer):
Replying to [comment:40 leif]:
> Replying to [comment:39 jdemeyer]:
> Details, please. ;-)
{{{
if command -v dpkg && ! command -v dpkg-architecture >/dev/null; then
}}}
should be
{{{
if command -v dpkg >/dev/null && ! command -v dpkg-architecture
>/dev/null; then
}}}
or
{{{
if ( command -v dpkg && ! command -v dpkg-architecture ) >/dev/null; then
}}}
Mixed usage of `cp` of `patch`, better always use `patch`.
On SunOS, you first patch `setup.py` and then copy a different version
over it.
Patching is better done using one `for` loop to prevent an error-prone
laundry list of patches to be applied.
Why call `./configure` with arguments `CC="$CC $CFLAGS" CXX="$CXX
$CXXFLAGS"`? Any why only on certain systems?
{{{
MAKE=make; export MAKE
make -i install
}}}
should be
{{{
$MAKE -j1 -i install
}}}
Remove this:
{{{
# Do not exit script if there is an error, but instead print an
# informative error message. This is helps in determining why the
# configuration, compilation or installation failed. So put this before
the
# build() function.
set +e # This is redundant here, but doesn't hurt to keep it... ;-)
}}}
Why this:
{{{
echo "Sleeping for three seconds before testing python"
sleep 3
}}}
I guess `EXTRAFLAGS` is only used inside the `spkg-install` script, so why
export it?
On SunOS, do we need the configure flag `--with-gcc="gcc -m64"` given that
`-m64` is already inside `$OPT`? Or, if `$OPT` does nothing, why specify
`$OPT`?
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11447#comment:41>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
