#11021: Fix "sage -info" and a bug when sourcing sage-env more than once
--------------------------------------------------------+-------------------
Reporter: jhpalmieri | Owner: leif
Type: defect | Status:
needs_review
Priority: major | Milestone:
sage-4.7.1
Component: packages | Keywords:
SPKG.txt SAGE.txt -info BUILD sage-env sage-sage sage-spkg
Work_issues: | Upstream: N/A
Reviewer: Kelvin Li, Leif Leonhardy, John Palmieri | Author: Leif
Leonhardy, Kelvin Li
Merged: | Dependencies:
--------------------------------------------------------+-------------------
Comment(by jhpalmieri):
I'm utterly tired of the message "Warning: Attempted to overwrite
SAGE_ROOT environment variable". Can we apply this patch to `sage-env`:
{{{
#!diff
diff --git a/sage-env b/sage-env
--- a/sage-env
+++ b/sage-env
@@ -50,7 +50,7 @@ if [ "$SAGE_ROOT" = "" ]; then
else
if [ -f "$SAGE_ROOT"/sage -a -d "$SAGE_ROOT"/spkg ]; then
# SAGE_ROOT points to a sage installation as expected
- if [ "$SAGE_ROOT" != "$GUESSED_SAGE_ROOT" ]; then
+ if [ -n "$GUESSED_SAGE_ROOT" -a "$SAGE_ROOT" !=
"$GUESSED_SAGE_ROOT" ]; then
echo "Warning: Attempted to overwrite SAGE_ROOT environment
variable"
fi
else
}}}
That will eliminate some of its occurrences.
Meanwhile, I'm happy with
[attachment:trac_11021-support_and_document_sage_-info_in_sage-
sage.scripts.patch] and [attachment:trac_11021-export_BUILD_in_sage-
env.scripts.patch]. [attachment:trac_11021-sage-spkg-
cleanup-v2-rebased_to_4.7.1.alpha4.patch] also looks good, and anyway I
think it's just a rebased version of a patch which already had a positive
review. This leaves [attachment:trac_11021-additional_changes_to_sage-
spkg.scripts.patch]. I'll try to work on that, and anyone else who wants
to is welcome.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11021#comment:24>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
