#11602: install_scripts should use "$@" instead of $*
----------------------+-----------------------------------------------------
Reporter: Stefan | Owner: jason
Type: defect | Status: needs_work
Priority: minor | Milestone: sage-4.7.2
Component: misc | Keywords: install_scripts, hg, command line
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
----------------------+-----------------------------------------------------
Changes (by leif):
* status: needs_review => needs_work
Comment:
Ahem,
* you really have to add the quotes around `$@` since this has a
different meaning, namely quoting ''each element of'' `$@`.
* `command` is a '''shell built-in''', and hence not an executable to be
found along `PATH`, so we need `shell=True` and a single string
containing `command -v ...` rather than a list of arguments.
* Removing `$SAGE_ROOT/local/bin` from `PATH` should IMHO be more robust
w.r.t. redundant slashs and `normpath()` or `realpath()`.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11602#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
