#11605: Typos in PARI's spkg-install (2.4.3.alpha.p5)
------------------------+---------------------------------------------------
Reporter: leif | Owner: tbd
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.7.1
Component: packages | Keywords: PARI spkg Cygwin
Work_issues: | Upstream: N/A
Reviewer: | Author:
Merged: | Dependencies:
------------------------+---------------------------------------------------
Changes (by leif):
* keywords: => PARI spkg Cygwin
Old description:
> Someone should have noticed this:
> {{{
> ./spkg-install: line 185: [: missing `]'
> Installing PARI/GP...
> }}}
>
> Here's the culprit:
> {{{
> #!sh
> build()
> {
> ...
>
> $MAKE $PARI_MAKEFLAGS gp
> if [ $? -ne 0]; then
> echo >&2 "Error: building PARI/GP failed."
> fi
> }
> }}}
> Note that also an `exit 1`(!) is missing there.
>
> (Two patches apply with fuzz 2 btw.)
New description:
Someone should have noticed this:
{{{
./spkg-install: line 185: [: missing `]'
Installing PARI/GP...
}}}
Here's the culprit:
{{{
#!sh
build()
{
...
$MAKE $PARI_MAKEFLAGS gp
if [ $? -ne 0]; then
echo >&2 "Error: building PARI/GP failed."
fi
}
}}}
Note that also an `exit 1` (!) is missing there.
(Two patches apply with fuzz 2 btw.)
----
'''New spkg: http://spkg-
upload.googlecode.com/files/pari-2.4.3.alpha.p7.spkg'''
'''md5sum: `fd153c3ee354402bb6fc835b9e8ecd9a pari-2.4.3.alpha.p7.spkg`'''
(This spkg is based on / includes the never merged p6 from #10240, see
comments below and there.)
----
== Changelog ==
=== pari-2.4.3.alpha.p7 (Leif Leonhardy, July 16th, 2011) ===
* #11605: Fix typo in spkg-install and add `exit 1` (again) in case
the build fails.
* Quote some more variables and filenames in messages.
=== pari-2.4.3.alpha.p6 (Dima Pasechnik, 22 April, 2011) ===
* made a proper check for libpari.dll on Cygwin, as described in
trac #10240
--
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11605#comment:4>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
