#11350: Fraction fields should know whether they are finite or not.
--------------------------------------------------------------+-------------
Reporter: SimonKing | Owner:
AlexGhitza
Type: enhancement | Status:
needs_review
Priority: major | Milestone:
sage-4.7.1
Component: algebra | Keywords:
fraction field, is_finite
Work_issues: | Upstream:
N/A
Reviewer: Robert Bradshaw, Jeroen Demeyer, John Palmieri | Author:
Simon King
Merged: | Dependencies:
--------------------------------------------------------------+-------------
Changes (by jhpalmieri):
* reviewer: Robert Bradshaw => Robert Bradshaw, Jeroen Demeyer, John
Palmieri
Old description:
> If I am not mistaken, a fraction field of an integral domain R is finite
> if and only if R is finite. Hence, we should not have a
> `NotImplementedError` but the following:
> {{{
> sage: Frac(QQ['a','b','c']).is_finite()
> False
> }}}
>
> Apply:
>
> [attachment:trac11350_fractionfield_is_finite.patch]
>
> [attachment:trac11350_docfix.patch]
New description:
If I am not mistaken, a fraction field of an integral domain R is finite
if and only if R is finite. Hence, we should not have a
`NotImplementedError` but the following:
{{{
sage: Frac(QQ['a','b','c']).is_finite()
False
}}}
Apply:
[attachment:trac_11350-combined.patch]
--
Comment:
I'm basically happy with the patches here, except for some wording and
formatting in the docstrings. I'm attaching a combined version of the two
patches, along with "delta" patches for each so you can see what I
changed. If you're happy with my changes, please give the ticket a
positive review.
(Basically: in [attachment:trac11350_fractionfield_is_finite.patch], I
changed the "NOTE" to an actual ".. note::" markup, and I reworded the
note a bit. In the other attachment, I reworded things a bit also. Since
the docstring there is not actually in the reference manual, since the
method starts with an underscore, I didn't bother putting in the "..
note::" markup. If you feel like doing that, go ahead.)
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11350#comment:22>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
