#11388: Allow start/stop recording exceptions in the coercion model
-----------------------------------------+----------------------------------
Reporter: robertwb | Owner: tbd
Type: defect | Status: needs_review
Priority: critical | Milestone: sage-4.7.1
Component: coercion | Keywords: debug, coercion,
exceptions
Work_issues: | Upstream: N/A
Reviewer: Luis Felipe Tabera Alonso | Author: Robert Bradshaw
Merged: | Dependencies:
-----------------------------------------+----------------------------------
Changes (by lftabera):
* keywords: => debug, coercion, exceptions
* reviewer: => Luis Felipe Tabera Alonso
* status: needs_info => needs_review
Old description:
> This was detected in the following speed regression
>
> In vanilla sage 4.6.2
> {{{
> sage: a=Integer(1000)
> sage: b=int(1000)
> sage: c=[0]
> sage: %timeit c*a
> 625 loops, best of 3: 21.2 µs per loop
> sage: %timeit c*b
> 625 loops, best of 3: 5.21 µs per loop
> }}}
>
> In vanilla sage 4.7.rc4
> {{{
> sage: a=Integer(1000)
> sage: b=int(1000)
> sage: c=[0]
> sage: %timeit c*a
> 625 loops, best of 3: 568 µs per loop
> sage: %timeit c*b
> 625 loops, best of 3: 5.13 µs per loop
> }}}
>
> By default the coercion model should not be recording exceptions ocurred
> in the execution of sage unless explicitely anabling reconding exceptions
> for debugging support.
New description:
This was detected in the following speed regression
In vanilla sage 4.6.2
{{{
sage: a=Integer(1000)
sage: b=int(1000)
sage: c=[0]
sage: %timeit c*a
625 loops, best of 3: 21.2 µs per loop
sage: %timeit c*b
625 loops, best of 3: 5.21 µs per loop
}}}
In vanilla sage 4.7.rc4
{{{
sage: a=Integer(1000)
sage: b=int(1000)
sage: c=[0]
sage: %timeit c*a
625 loops, best of 3: 568 µs per loop
sage: %timeit c*b
625 loops, best of 3: 5.13 µs per loop
}}}
By default the coercion model should not be recording exceptions ocurred
in the execution of sage unless explicitely anabling reconding exceptions
for debugging support.
Apply:
* 11388-coercion-speed.3.patch
* 11388-coercion-speed-referee-patch.patch
--
Comment:
I give a positive review to the patch from Robert,
I just suggest some more verbosity in the documentation, as added in my
patch.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11388#comment:10>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
