#10319: segmentation fault in sparse rational matrix manipulations
------------------------------+---------------------------------------------
Reporter: monniaux | Owner: jason, was
Type: defect | Status: positive_review
Priority: critical | Milestone: sage-4.7.1
Component: linear algebra | Keywords:
Work_issues: | Upstream: N/A
Reviewer: Rob Beezer | Author: Johan Bosman
Merged: | Dependencies:
------------------------------+---------------------------------------------
Changes (by rbeezer):
* status: needs_review => positive_review
* reviewer: => Rob Beezer
Comment:
This looks real good. I have the symptom (the reproducible segfault) on
my machine and this is a cure. And the code looks sound. Passes all long
tests on 4.7.1.alpha4.
Yes, a double-colon would be needed to set off the code block for the bug-
fix-verification addition. {{{sage/matrix/matrix_rational_sparse.pyx}}}
is a total mess with regard to documentation and is not even being
included in the PDF or HTML versions right now. So I see little point in
messing around with an additional patch to clean that up -- the whole file
needs work. I've put it on my to-do list.
So: positive review.
--
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10319#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica,
and MATLAB
--
You received this message because you are subscribed to the Google Groups
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to
[email protected].
For more options, visit this group at
http://groups.google.com/group/sage-trac?hl=en.
