#10190: developer's guide: warnings & notes about commit message, cloning and
setting the text editor
-----------------------------+----------------------------------------------
   Reporter:  mvngu          |          Owner:  mvngu                       
       Type:  enhancement    |         Status:  needs_work                  
   Priority:  major          |      Milestone:  sage-4.7.1                  
  Component:  documentation  |       Keywords:  Mercurial, developer's guide
Work_issues:                 |       Upstream:  N/A                         
   Reviewer:                 |         Author:  Minh Van Nguyen             
     Merged:                 |   Dependencies:                              
-----------------------------+----------------------------------------------
Changes (by jhpalmieri):

  * status:  needs_review => needs_work


Comment:

 Here are some comments: on line 107 of the patch, "Mercurial queues fits"
 — change "fits" to "fit".

 Lines 234-239: I don't agree that the Sage interface is limiting: you can
 execute any Mercurial command with the Sage library repo, for example, by
 typing `hg_sage("command")`.  It is true that the number of options
 available via tab completion is not great, in particular missing anything
 having to do with queues.

 I don't think that we need the same warning about cloning three different
 times, especially since the lines before give a link to the section on
 creating a clone, which includes the original warning.  (I'm also hoping
 that #6495 will help speed up the cloning process.)

 Regarding `HGEDITOR` etc., it seems to me that you don't need to enter the
 full path for the editor.  I tried with `export HGEDITOR=vim`, and
 similarly for the `editor` setting in `.hgrc`, and it worked fine.  Do we
 need so much detail for this setting, or can we just advise users to set
 their `EDITOR` environment variable, perhaps with a link to
 [http://mercurial.selenic.com/wiki/editor]?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10190#comment:16>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to