#10607: Update phcpack to latest verson
---------------------------------+------------------------------------------
   Reporter:  mhampton           |          Owner:  tbd                         
       
       Type:  enhancement        |         Status:  needs_work                  
       
   Priority:  major              |      Milestone:  sage-4.7.1                  
       
  Component:  optional packages  |       Keywords:  phcpack, homotopy solver, 
numerical
Work_issues:                     |       Upstream:  N/A                         
       
   Reviewer:                     |         Author:  Marshall Hampton            
       
     Merged:                     |   Dependencies:                              
       
---------------------------------+------------------------------------------
Changes (by jhpalmieri):

  * status:  needs_review => needs_work


Comment:

 Oops, I made a mistake in my suggestion.  After the print statement ("This
 package does not work..."), the program needs to exit.  You could add
 `import sys` at the beginning and then put `sys.exit(1)` after the
 message.  This will cause an error, and I'm not sure whether you want that
 or not -- it will say
 {{{
 ****************************************************
 ('SunOS', 'fulvia', '5.10', 'Generic_127128-11', 'i86pc') SunOS i86pc
 This package does not work on OpenSolaris on x86.

 real    0m0.148s
 user    0m0.014s
 sys     0m0.023s
 sage: An error occurred while installing phc-2.3.65
 Please email sage-devel http://groups.google.com/group/sage-devel
 explaining the problem and send the relevant part of
 ...
 }}}
 You could use `sys.exit(0)` instead, in which case it would say
 {{{
 ****************************************************
 ('SunOS', 'fulvia', '5.10', 'Generic_127128-11', 'i86pc') SunOS i86pc
 This package does not work on OpenSolaris on x86.

 real    0m0.126s
 user    0m0.014s
 sys     0m0.023s
 Successfully installed phc-2.3.65
 Now cleaning up tmp files.
 Making Sage/Python scripts relocatable...
 Making script relocatable
 Finished installing phc-2.3.65.spkg
 }}}
 In either case, I would print a blank line before the warning message, to
 highlight it, and maybe use "ERROR: This package ...".  I think using
 `sys.exit(1)` is better than `sys.exit(0)`, since it didn't really
 successfully install phc.

 Do you know of anyone with access to Mac OS X 10.4 (ppc and intel) and
 10.5 (intel) machines, to test there?

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10607#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to