#11611: Equal PARI integers have different hashes
-----------------------------+----------------------------------------------
   Reporter:  jdemeyer       |          Owner:  jdemeyer                    
       Type:  defect         |         Status:  positive_review             
   Priority:  critical       |      Milestone:  sage-4.7.2                  
  Component:  number fields  |       Keywords:  pari cgetg integer ideal hnf
Work_issues:                 |       Upstream:  N/A                         
   Reviewer:                 |         Author:  Jeroen Demeyer              
     Merged:                 |   Dependencies:                              
-----------------------------+----------------------------------------------

Comment(by tornaria):

 As William, I read the ticket description and the patch and I don't
 understand what is really the cause of the issue and why the patch fixes
 it.

 I'd encourage Jeroen to add a comment explaining this bit and, if
 possible, to split the patch in two parts: a "fix the issue" part and a
 "cleanup" part (in the order that is most convenient).

 ----

 I'm also wondering if the hash of a pari integer should match the hash of
 the corresponding sage or python integers. That is carefully considered in
 the sage integers/rationals, etc. The principle is that two values that
 are equivalent (for the purposes of equality comparision) should have the
 same hash to avoid nastiness in using the values as dictionary keys. The
 same would be true for some other pari types.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11611#comment:9>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to