#11602: install_scripts should use "$@" instead of $*
------------------------------+---------------------------------------------
   Reporter:  Stefan          |          Owner:  jason                          
  
       Type:  defect          |         Status:  positive_review                
  
   Priority:  minor           |      Milestone:  sage-4.7.2                     
  
  Component:  misc            |       Keywords:  install_scripts, hg, command 
line
Work_issues:                  |       Upstream:  N/A                            
  
   Reviewer:  Leif Leonhardy  |         Author:  John Palmieri                  
  
     Merged:                  |   Dependencies:                                 
  
------------------------------+---------------------------------------------

Old description:

> When using a script created by Sage's install_scripts() function,
> parameters with spaces cause problems. Example:
> {{{
> From sage:
>
> sage: os.mkdir("temp")
> sage: install_scripts("temp")
> sage: quit
>
> From shell:
>
> $ cd temp
> $ mkdir hgtest
> $ cd hgtest
> $ ../hg init
> $ ../hg commit -m"Two words"
> abort: words: No such file or directory
> $ ../hg commit -m"Oneword"
> nothing changed
> }}}
>
> Apparently this was discussed on the mailing list back in 2008:
> https://groups.google.com/forum/#!msg/sage-devel/oeFrvqWiP_s/o8mKO-4OAKkJ
>
> It seems that the solution is to make install_scripts write "$@" instead
> of $* .
>
> --------
>
> Apply [attachment:trac_11602-install-scripts.v3.patch].

New description:

 When using a script created by Sage's install_scripts() function,
 parameters with spaces cause problems. Example:
 {{{
 From sage:

 sage: os.mkdir("temp")
 sage: install_scripts("temp")
 sage: quit

 From shell:

 $ cd temp
 $ mkdir hgtest
 $ cd hgtest
 $ ../hg init
 $ ../hg commit -m"Two words"
 abort: words: No such file or directory
 $ ../hg commit -m"Oneword"
 nothing changed
 }}}

 Apparently this was discussed on the mailing list back in 2008:
 https://groups.google.com/forum/#!msg/sage-devel/oeFrvqWiP_s/o8mKO-4OAKkJ

 It seems that the solution is to make install_scripts write "$@" instead
 of $* .

 --------

 Apply only [attachment:trac_11602-install-scripts.v4.patch].

--

Comment(by leif):

 Positive review also for version 4.

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/11602#comment:30>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to