#10588: Upgrade to matplotlib 1.0.1
---------------------------+------------------------------------------------
    Reporter:  ryan        |         Owner:  tbd                   
        Type:  task        |        Status:  closed                
    Priority:  major       |     Milestone:  sage-4.6.2            
   Component:  packages    |    Resolution:  fixed                 
    Keywords:  matplotlib  |   Work_issues:                        
    Upstream:  N/A         |      Reviewer:  Jason Grout, Dan Drake
      Author:  Ryan Grout  |        Merged:  sage-4.6.2.alpha1     
Dependencies:              |  
---------------------------+------------------------------------------------

Comment(by leif):

 Replying to [comment:10 leif]:
 > Also, this spkg reintroduced the race condition in creating the TeX font
 cache directory (#10159), because the patch to `font_manager.py` was
 dropped, apparently without having checked whether the issue had really
 been fixed (see #11686):

 Whoops, the situation is a bit different:

 While the spkg here ''did'' reintroduce the bug, it didn't ''because a
 patch was removed'', but because it was based on an obsolete spkg, and not
 that of #10159 (which was merged into Sage 4.6.1.alpha0):
 {{{
 == Changelog ==
 === matplotlib 1.0.1 (Ryan Grout, 10 Jan 2011) ===
  * Update to matplotlib 1.0.1.  Fixes a handful of annoying bugs in SAGE.

 === matplotlib 1.0.0 (Jason Grout, 01 Oct 2010) ===
  * Update to matplotlib 1.0.0.  Include two upstream fixes that were
 committed since 1.0.0.
 }}}
 vs.
 {{{
 == Changelog ==

 === matplotlib 1.0.0.p0 (John Palmieri, 23 Oct 2010) ===
  * Patch __init__.py, finance.py, and texmanager.py to avoid race
    conditions when creating directories.

 === matplotlib 1.0.0 (Jason Grout, 01 Oct 2010) ===
  * Update to matplotlib 1.0.0.  Include two upstream fixes that were
    committed since 1.0.0.
 }}}

 So the bug is still in the upstream sources, and in the '''same'''
 file(s), e.g. `src/lib/matplotlib/texmanager.py`:
 {{{
 #!sh
 ~/Sage/spkgs/matplotlib-1.0.1$ grep -n -C2 mkdir
 src/lib/matplotlib/texmanager.py
 90-        shutil.move(oldcache, texcache)
 91-    if not os.path.exists(texcache):
 92:        os.mkdir(texcache)
 93-
 94-    _dvipng_hack_alpha = None
 --
 132-
 133-        if not os.path.isdir(self.texcache):
 134:            os.mkdir(self.texcache)
 135-        ff = rcParams['font.family'].lower()
 136-        if ff in self.font_families:
 }}}
 (Just to clarify; this certainly belongs to the new ticket, #11686.)

-- 
Ticket URL: <http://trac.sagemath.org/sage_trac/ticket/10588#comment:11>
Sage <http://www.sagemath.org>
Sage: Creating a Viable Open Source Alternative to Magma, Maple, Mathematica, 
and MATLAB

-- 
You received this message because you are subscribed to the Google Groups 
"sage-trac" group.
To post to this group, send email to [email protected].
To unsubscribe from this group, send email to 
[email protected].
For more options, visit this group at 
http://groups.google.com/group/sage-trac?hl=en.

Reply via email to